search

jetstack / terraform-google-gke-cluster

A Terraform module to create a best-practise Google Kubernetes Engine (GKE) cluster.
Apache License 2.0
161 stars 87 forks source link

Set terraform required version #31

Closed wwwil closed 5 years ago

wwwil commented 5 years ago

The module and example should explicitly specify a required Terraform version, especially with that changes that 0.12 introduces.

jetstack-bot commented 5 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wwwil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/terraform-google-gke-cluster/blob/master/OWNERS)~~ [wwwil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
haysclark commented 5 years ago

sorry about that, I didn't realize I was logged in as the bot's account. :D

I added the /lgtm

wwwil commented 5 years ago

@haysclark No problem, this actually highlighted a bug with our Prow (has now been fixed) and got my PR merged faster 👍

repo-lockdown[bot] commented 4 years ago

This project is now deprecated so we aren't accepting any further changes.