jetstack / terraform-google-gke-cluster

A Terraform module to create a best-practise Google Kubernetes Engine (GKE) cluster.
Apache License 2.0
161 stars 87 forks source link

Add cloud NAT #46

Closed wwwil closed 4 years ago

wwwil commented 5 years ago

Close #36. Add cloud router, static address and NAT to example project with names set with input variables.

Add explanation of private node and Cloud NAT to close #35.

Signed-off-by: wwwil wwwil.squires@gmail.com

wwwil commented 4 years ago

I'm gonna hold off looking into test failures until this PR to improve the script is merged: https://github.com/jetstack/terraform-google-gke-cluster/pull/59

philwinder commented 4 years ago

Thank you for this. Saved my bacon.

wwwil commented 4 years ago

/retest

znat commented 4 years ago

Hi there, we're really excited with this feature and look forward to it being merged 💯

jetstack-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wwwil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/terraform-google-gke-cluster/blob/master/OWNERS)~~ [wwwil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
wwwil commented 4 years ago

Hi there, we're really excited with this feature and look forward to it being merged 💯

Hey @znat! Thanks for your interest and sorry for the delay! We've had some difficulty resourcing this module, and for many of our projects have switched to using Google's GKE module.

I'm going to work on this module today to clear the backlog of PRs and release a new version, though it's likely this will be final version. We're then planning to create an example Terraform project like the example in this module, but using Google's GKE module, as well as guidance on how to migrate.

repo-lockdown[bot] commented 4 years ago

This project is now deprecated so we aren't accepting any further changes.