search

jetstack / terraform-google-gke-cluster

A Terraform module to create a best-practise Google Kubernetes Engine (GKE) cluster.
Apache License 2.0
161 stars 87 forks source link

Add support for specifying a version for node pools #67

Closed simonswine closed 4 years ago

simonswine commented 4 years ago

Signed-off-by: Christian Simon simon@swine.de

wwwil commented 4 years ago

/approve /lgtm

jetstack-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: simonswine, wwwil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/terraform-google-gke-cluster/blob/master/OWNERS)~~ [wwwil] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
wwwil commented 4 years ago

/lgtm

wwwil commented 4 years ago

I've merged this to unblock using it but have added a follow up PR here #71

repo-lockdown[bot] commented 4 years ago

This project is now deprecated so we aren't accepting any further changes.