Closed georgedriver closed 5 years ago
@georgedriver: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it.
Thanks for your pull request. Before we can look at it, you'll need to add a 'DCO signoff' to your commits.
:memo: Please follow instructions in the contributing guide to update your commits with the DCO
Full details of the Developer Certificate of Origin can be found at developercertificate.org.
The list of commits missing DCO signoff:
Hi @georgedriver. Thanks for your PR.
I'm waiting for a jetstack member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
I understand the commands that are listed here.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: To fully approve this pull request, please assign additional approvers. We suggest the following additional approver: munnerz
If they are not already assigned, you can assign the PR to them by writing /assign @munnerz
in a comment when ready.
The full list of commands accepted by this bot can be found here.
The pull request process is described here
@georgedriver Thanks for the PR. Can you please sign-off and add a release note as described here: https://github.com/kubernetes/community/blob/master/contributors/guide/release-notes.md
/unassign /assign @georgedriver
Add alicloud support.
/assign @JoshVanL /assign @munnerz