jetstack / version-checker

Kubernetes utility for exposing image versions in use, compared to latest available upstream, as metrics.
https://jetstack.io
Apache License 2.0
665 stars 76 forks source link

Fix: docker hub images if they have no timestamp #130

Closed davidcollom closed 8 months ago

davidcollom commented 8 months ago

Under certain conditions, the docker hub repository doesn't have the date in whcih the image was pushed, therefore resulting in version-checker not monitoring the image what so ever.

This changes the logic some what for docker hub repositories as if the timestamp is missing we default to the Unix Timestamp in the hope that SemVer checking takes precidence.

The likely hood of these images without timestamps being the latest is highly unlikely or there's a data integrity issue with the repository its self.

Resolves #123

joshw123 commented 8 months ago

LGTM! :)

jwitko commented 8 months ago

Thank you @davidcollom !