search

jetstack / version-checker

Kubernetes utility for exposing image versions in use, compared to latest available upstream, as metrics.
https://jetstack.io
Apache License 2.0
665 stars 76 forks source link

Fix: Update secret template to support GHCR token #132

Closed jwitko closed 8 months ago

jwitko commented 8 months ago

This fixes #124

wagnst commented 8 months ago

can confirm having the same issue 

Error: couldn't find key ghcr.token in Secret version-checker/version-checker
szpaczyna commented 8 months ago

You might also want to adjust the first line of secret.yaml file using the following:

{{- if or .Values.acr.refreshToken .Values.acr.username .Values.acr.password .Values.docker.token .Values.ecr.accessKeyID .Values.ecr.secretAccessKey .Values.ecr.sessionToken .Values.docker.username .Values.docker.password .Values.gcr.token .Values.quay.token .Values.ghcr.token (not (eq (len .Values.selfhosted) 0)) }}
jwitko commented 8 months ago

Sorry @davidcollom , was at a conference last week and didn't see these comments. Thanks for merging and likely taking care of the extra stuff on your own.