search

jetstack / version-checker

Kubernetes utility for exposing image versions in use, compared to latest available upstream, as metrics.
https://jetstack.io
Apache License 2.0
691 stars 78 forks source link

Helm Chart: add imagePullSecret to serviceaccount #186

Closed 2mf closed 4 months ago

2mf commented 5 months ago

In my work environment, we have have a local repository which does mirror and proxy external image repository for security reasons, it is essential to have imagePullSecrets added to the serviceaccount otherweise version-checker itself can not be pulled and started.

theodore86 commented 5 months ago

+1

davidcollom commented 4 months ago

Some Unit tests on the helm chart would have been good - https://github.com/jetstack/version-checker/blob/main/deploy/charts/version-checker/tests/serviceaccount_test.yaml But I can add them in follow up PR.

Thanks for the contribution! 🎉 👍