search

jetstack / version-checker

Kubernetes utility for exposing image versions in use, compared to latest available upstream, as metrics.
https://jetstack.io
Apache License 2.0
661 stars 76 forks source link

Cleanup Helm Templates #215

Open davidcollom opened 4 days ago

davidcollom commented 4 days ago

This cleans up some of the output from helm template and also duirng installation to be cleaner and reduce whitespace as raised in #187.

On its own:

---
# Source: version-checker/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: version-checker
  labels:

    app.kubernetes.io/name: version-checker
    helm.sh/chart: version-checker-v0.6.0
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "v0.6.0"
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/name: version-checker
      app.kubernetes.io/instance: release-name
  template:
    metadata:
      labels:
        app.kubernetes.io/name: version-checker
        helm.sh/chart: version-checker-v0.6.0
        app.kubernetes.io/instance: release-name
        app.kubernetes.io/version: "v0.6.0"
        app.kubernetes.io/managed-by: Helm
      annotations:
        prometheus.io/path: "/metrics"
        prometheus.io/scrape: "true"
        prometheus.io/port: "8080"
        enable.version-checker.io/version-checker: "true"
    spec:
      serviceAccountName: version-checker
      containers:
      - name: version-checker
        image: "quay.io/jetstack/version-checker:v0.6.0"
        imagePullPolicy: IfNotPresent
        ports:
        - name: metrics
          containerPort: 8080
        command: ["version-checker"]
        args:
          - "--image-cache-timeout=30m"
          - "--log-level=info"
          - "--metrics-serving-address=0.0.0.0:8080"
          - "--test-all-containers=true"
        resources:
            {}
        livenessProbe:
          httpGet:
            path: /readyz
            port: 8080
          initialDelaySeconds: 3
          periodSeconds: 3
        readinessProbe:
          httpGet:
            path: /readyz
            port: 8080
          initialDelaySeconds: 3
          periodSeconds: 3
        env:
      volumes:

With Values:

---
# Source: version-checker/templates/deployment.yaml
apiVersion: apps/v1
kind: Deployment
metadata:
  name: version-checker
  labels:
    app.kubernetes.io/name: version-checker
    helm.sh/chart: version-checker-v0.6.0
    app.kubernetes.io/instance: release-name
    app.kubernetes.io/version: "v0.6.0"
    app.kubernetes.io/managed-by: Helm
spec:
  replicas: 1
  selector:
    matchLabels:
      app.kubernetes.io/name: version-checker
      app.kubernetes.io/instance: release-name
  template:
    metadata:
      labels:
        app.kubernetes.io/name: version-checker
        helm.sh/chart: version-checker-v0.6.0
        app.kubernetes.io/instance: release-name
        app.kubernetes.io/version: "v0.6.0"
        app.kubernetes.io/managed-by: Helm
      annotations:
        prometheus.io/path: "/metrics"
        prometheus.io/scrape: "true"
        prometheus.io/port: "8080"
        enable.version-checker.io/version-checker: "true"
    spec:
      serviceAccountName: version-checker
      containers:
      - name: version-checker
        image: "quay.io/jetstack/version-checker:v0.6.0"
        imagePullPolicy: IfNotPresent
        ports:
        - name: metrics
          containerPort: 8080
        command: ["version-checker"]
        args:
          - "--image-cache-timeout=30m"
          - "--log-level=info"
          - "--metrics-serving-address=0.0.0.0:8080"
          - "--test-all-containers=true"
        resources:
            {}
        livenessProbe:
          httpGet:
            path: /readyz
            port: 8080
          initialDelaySeconds: 3
          periodSeconds: 3
        readinessProbe:
          httpGet:
            path: /readyz
            port: 8080
          initialDelaySeconds: 3
          periodSeconds: 3
        env:
        # ACR
        - name: VERSION_CHECKER_ACR_REFRESH_TOKEN
          valueFrom:
            secretKeyRef:
              name: version-checker
              key: acr.refreshToken
        # GHCR
        - name: VERSION_CHECKER_GHCR_TOKEN
          valueFrom:
            secretKeyRef:
              name: version-checker
              key: ghcr.token
      volumes:
        - name: version-checker
          secret:
            secretName: version-checker

Comments are still there, but truncated and only show, IF the respective repository configuration has been sent.

davidcollom commented 4 days ago 
metadata:
  name: version-checker
  labels:

    app.kubernetes.io/name: version-checker
    helm.sh/chart: version-checker-v0.6.0