search

jetstack / version-checker

Kubernetes utility for exposing image versions in use, compared to latest available upstream, as metrics.
https://jetstack.io
Apache License 2.0
705 stars 79 forks source link

[BUG] existingSecret value not in default values nor in docs #229

Closed juan-vg closed 3 months ago

juan-vg commented 3 months ago

Describe the bug The existingSecret value is not in default values nor in docs

Expected behavior The ability to use an existing secret should be documented

Environment:

hawksight commented 3 months ago

@juan-vg thank you for raising the issue.

You are correct, the .Values.existingSecret is used here, but I can't see it in the values.

We will try to make sure this is fixed.

We can probably find something to lint / validate the chart to catch any undocumented values in the future too. But perhaps that will be another issue :).

We also welcome contributions too if you have time to fix.

ToDo

juan-vg commented 3 months ago

By the way, another value not present in defaults/docs: nameOverride