Closed AucT closed 6 days ago
The changes encompass the addition and modification of multiple HTML and CSS files within the Beaver theme. Key updates include the introduction of responsive image handling templates, restructuring of existing HTML layouts for improved maintainability, and the inclusion of a new CSS file to standardize SVG image sizing. Additionally, a new entry was added to the .gitignore
file to prevent tracking of unnecessary image files. These alterations aim to enhance the overall user experience and optimize image rendering across various pages.
Files | Change Summary |
---|---|
static/assets/css/careers.css |
Added styling for SVG images within .pp-infobox-image , setting width to 35 pixels. |
themes/beaver/layouts/404.html |
Introduced a partial template call to render an image on the 404 error page. |
themes/beaver/layouts/clients/single.html |
Replaced manual image handling with a partial template for cover images and streamlined gallery item handling. Introduced dynamic rendering for client case studies. |
themes/beaver/layouts/page/about.html |
Simplified image handling by retrieving the cover image from a nested parameter and using a partial template for rendering. |
themes/beaver/layouts/page/careers.html |
Restructured HTML layout, reorganized CSS resource loading, and introduced partial templates for images and testimonials. |
themes/beaver/layouts/page/free-consultation.html |
Updated image source paths for consistency and better management. |
themes/beaver/layouts/partials/clients/grid-single.html |
Removed specific image resizing operations and replaced logo handling with a partial template. |
themes/beaver/layouts/partials/img/*.html |
Introduced multiple new partial templates for responsive image rendering, optimizing image handling with srcset attributes for various widths. |
themes/beaver/layouts/partials/page/testimonials.html |
Replaced direct <img> tag implementations with partial templates for improved image handling. |
themes/beaver/layouts/services/single.html |
Removed multiple image resizing logic and replaced it with a call to a partial template for rendering the cover image. |
.gitignore |
Added a rule to ignore files with the .diff.png extension to prevent tracking unnecessary image files. |
sequenceDiagram
participant User
participant Webpage
participant ImageService
participant Template
User->>Webpage: Request Page
Webpage->>Template: Render Page
Template->>ImageService: Fetch Image
ImageService-->>Template: Return Image
Template-->>Webpage: Render Image
Webpage-->>User: Display Page
Objective | Addressed | Explanation |
---|---|---|
Provide height & width per images to optimize CLS (34) | ✅ |
🐇 In a world of code, so bright and new,
Changes abound, like morning dew.
Images dance, responsive and fair,
With templates and styles, we show we care.
A hop and a skip, through lines we weave,
A polished site, we all believe! 🌟
This is not related to #34 let's remove link
@AucT you can merge tomorrow morning.
@AucT please create 3 issues to fix stuff after review
@AucT please rebase
There is breaking change, need to revert id deletion
++
Found some issue on about us
++ fixed
Closes #34
This pr doesn't include technologies image replacement as they require another issue and pr. Need to redo technologies block to use flexbox/grid and technologies.yml. Also extract it to partial.
🎤 drop
Summary by CodeRabbit
Summary by CodeRabbit
New Features
.gitignore
to exclude SnapDiff runtime files, improving version control management.Bug Fixes
Documentation