jetthoughts / jetthoughts.github.io

0 stars 0 forks source link

Add extract image resizing #106

Closed AucT closed 6 days ago

AucT commented 1 week ago

Closes #34

This pr doesn't include technologies image replacement as they require another issue and pr. Need to redo technologies block to use flexbox/grid and technologies.yml. Also extract it to partial.

🎤 drop

Summary by CodeRabbit

Summary by CodeRabbit

coderabbitai[bot] commented 1 week ago

Walkthrough

The changes encompass the addition and modification of multiple HTML and CSS files within the Beaver theme. Key updates include the introduction of responsive image handling templates, restructuring of existing HTML layouts for improved maintainability, and the inclusion of a new CSS file to standardize SVG image sizing. Additionally, a new entry was added to the .gitignore file to prevent tracking of unnecessary image files. These alterations aim to enhance the overall user experience and optimize image rendering across various pages.

Changes

Files Change Summary
static/assets/css/careers.css Added styling for SVG images within .pp-infobox-image, setting width to 35 pixels.
themes/beaver/layouts/404.html Introduced a partial template call to render an image on the 404 error page.
themes/beaver/layouts/clients/single.html Replaced manual image handling with a partial template for cover images and streamlined gallery item handling. Introduced dynamic rendering for client case studies.
themes/beaver/layouts/page/about.html Simplified image handling by retrieving the cover image from a nested parameter and using a partial template for rendering.
themes/beaver/layouts/page/careers.html Restructured HTML layout, reorganized CSS resource loading, and introduced partial templates for images and testimonials.
themes/beaver/layouts/page/free-consultation.html Updated image source paths for consistency and better management.
themes/beaver/layouts/partials/clients/grid-single.html Removed specific image resizing operations and replaced logo handling with a partial template.
themes/beaver/layouts/partials/img/*.html Introduced multiple new partial templates for responsive image rendering, optimizing image handling with srcset attributes for various widths.
themes/beaver/layouts/partials/page/testimonials.html Replaced direct <img> tag implementations with partial templates for improved image handling.
themes/beaver/layouts/services/single.html Removed multiple image resizing logic and replaced it with a call to a partial template for rendering the cover image.
.gitignore Added a rule to ignore files with the .diff.png extension to prevent tracking unnecessary image files.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant Webpage
    participant ImageService
    participant Template

    User->>Webpage: Request Page
    Webpage->>Template: Render Page
    Template->>ImageService: Fetch Image
    ImageService-->>Template: Return Image
    Template-->>Webpage: Render Image
    Webpage-->>User: Display Page

Assessment against linked issues

Objective Addressed Explanation
Provide height & width per images to optimize CLS (34)

Possibly related PRs

Poem

🐇 In a world of code, so bright and new,
Changes abound, like morning dew.
Images dance, responsive and fair,
With templates and styles, we show we care.
A hop and a skip, through lines we weave,
A polished site, we all believe! 🌟


Recent review details **Configuration used: .coderabbit.yaml** **Review profile: CHILL**
Commits Files that changed from the base of the PR and between a334b8c9e2a9209053e9aa8a9335cb96cff72aba and e485732e10fa7db7026171f20866748d8a83fd86.
Files ignored due to path filters (8) * `tests/fixtures/screenshots/clients.png` is excluded by `!**/*.png` * `tests/fixtures/screenshots/clients/_clients.png` is excluded by `!**/*.png` * `tests/fixtures/screenshots/clients/_cta-contact_us.png` is excluded by `!**/*.png` * `tests/fixtures/screenshots/clients/_footer.png` is excluded by `!**/*.png` * `tests/fixtures/screenshots/homepage/_clients.png` is excluded by `!**/*.png` * `tests/fixtures/screenshots/homepage/_cta-contact_us.png` is excluded by `!**/*.png` * `tests/fixtures/screenshots/homepage/_footer.png` is excluded by `!**/*.png` * `tests/fixtures/screenshots/homepage/_testimonials.png` is excluded by `!**/*.png`
Files selected for processing (1) * .gitignore (1 hunks)
Files skipped from review due to trivial changes (1) * .gitignore
--- Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
pftg commented 1 week ago

This is not related to #34 let's remove link

pftg commented 1 week ago

@AucT you can merge tomorrow morning.

pftg commented 6 days ago

@AucT please create 3 issues to fix stuff after review

pftg commented 6 days ago

@AucT please rebase

AucT commented 6 days ago

There is breaking change, need to revert id deletion

++

AucT commented 6 days ago

Found some issue on about us Learn More About Us and Our Story JetThoughts 2024-09-12 21-35-55

Learn More About Us and Our Story JetThoughts 2024-09-12 21-36-32

++ fixed