search

jettro / c3-angular-directive

Contains angularjs directives that use c3js to create good looking graphs
http://jettro.github.io/c3-angular-directive/
MIT License
203 stars 98 forks source link

Issue #159: Exposed rescale-zoom option #160

Closed gustavodegeus closed 6 years ago

gustavodegeus commented 7 years ago

A small change to fix issue #159. Added a new parameter to enable c3 rescale-zoom if necessary.

jettro commented 7 years ago

I tried this, but to me it doesn't seem to work. I can zoom on the bar chart you created in the sample, but the y-axis does not scale when I zoom. Are you sure it works? Or maybe I misunderstand what it should do.

gustavodegeus commented 7 years ago

Hi, yeah it works. Follow couple screenshots.

Normal chart: image

Zoomed in: image

Let me know if you have any concern.

Thanks!

jettro commented 7 years ago

I tried it on my local machine (Apple) in Safari and Chrome but the axis did not change for me. Wil try to build it explicitly and see what happens.

On Wed, Mar 15, 2017 at 1:58 PM, Gustavo de Geus notifications@github.com wrote:

Hi, yeah it works. Follow couple screen shoots.

Normal chart: [image: image] https://cloud.githubusercontent.com/assets/5770009/23949359/5540253c-095d-11e7-8d51-a3f55bc1a4c2.png

Zoomed in: [image: image] https://cloud.githubusercontent.com/assets/5770009/23949390/68383274-095d-11e7-8246-4ea6146bae7e.png

Let me know if you have any concern.

Thanks!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jettro/c3-angular-directive/pull/160#issuecomment-286733452, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJIt8skISv2h2c7bNyqJBkCQQUj-kbCks5rl-B3gaJpZM4MdH_8 .

-- Jettro Coenradie http://www.gridshore.nl

gustavodegeus commented 7 years ago

I increased the number of data-points to make it easier to test. Let me know if you are still having issues.

Thank you!