Try to remove the Fuzzer used for websocket testing.

jetty / jetty.project

Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more

https://eclipse.dev/jetty

Other

3.83k stars 1.91k forks source link

Try to remove the Fuzzer used for websocket testing. #10788

Open lachlan-roberts opened 11 months ago

lachlan-roberts commented 11 months ago

The WebSocket Fuzzer makes the testing more complex, and introduces some other potential issues by writing through the endpoint without going through WebSocket flushers and changing the WebSocketSessionState.

Investigate whether this is necessary and try to reduce/remove its usage if not.

gregw commented 10 months ago

At the very least, can we not call it a Fuzzer, since it does not introduce random data, it is not a Fuzzer... it is just a TestUtil.

I have no problem with retaining it, but it should be implemented in a reasonable way and not use EndPoint directly... unless to deliberately inject EOFs for testing.