search

jetty / jetty.project

Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more
https://eclipse.dev/jetty
Other
3.83k stars 1.91k forks source link

WebSocketUpgradeFilter started consuming much more time in 10.0.18 than in 9.4.48 #11055

Open captim opened 9 months ago

captim commented 9 months ago

Jetty version(s) 10.0.18

Java version/vendor (use: java -version) openjdk version "11.0.11" 2021-04-20 OpenJDK Runtime Environment AdoptOpenJDK-11.0.11+9 (build 11.0.11+9) OpenJDK 64-Bit Server VM AdoptOpenJDK-11.0.11+9 (build 11.0.11+9, mixed mode)

OS type/version Windows 10

Description After updating jetty 9.4.48->10.0.18 org.eclipse.jetty.websocket.servlet.WebSocketUpgradeFilter.doFilter() started consuming much more time than before (before update own time of this method was 0). Untitled

How to reproduce?

lachlan-roberts commented 8 months ago

@captim do you have more information of where it is spending its time in WebSocketUpgradeFilter.doFilter(), a deeper stacktrace might help because not much is happening in directly in this method.

Is the traffic websocket upgrade requests which are being upgraded, or are they non-upgrade requests which are spending more time to pass through here than before.