Closed olamy closed 1 month ago
The idea is to remove code we maintain and using proven existing solution. Why having code to implement an openid provider as some solutions exist already ;)
@lachlan-roberts init of keycloak done via some API usage. remove of this huge json import file.
result of the cleanup
I'm not 100% sure the rules adding new dependencies, but if you're sure we can add these for testing then LGTM.
I don't understand the problem. It's just a test module not even deployed/distributed so adding dependency doesn't have any impact.
Although I still prefer to use Jetty HttpClient for the testing if possible.
The problem is to extract data from the returned HTML. It's not like if parsing HTML was like parsing structured/well-formed data :) We can do it and I will have a try as it's probably not too complicated, but I feel like re-inventing the wheel.
@lachlan-roberts using our own Jetty HttpClient done