jetty / jetty.project

Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more
https://eclipse.dev/jetty
Other
3.86k stars 1.91k forks source link

Jetty 12.0.x Simplify tests with OpenId by using an exising openid provider and avoid extra not necessary maven modules #12274

Closed olamy closed 1 month ago

olamy commented 2 months ago
olamy commented 2 months ago

The idea is to remove code we maintain and using proven existing solution. Why having code to implement an openid provider as some solutions exist already ;)

olamy commented 2 months ago

@lachlan-roberts init of keycloak done via some API usage. remove of this huge json import file.

result of the cleanup

image

olamy commented 2 months ago

I'm not 100% sure the rules adding new dependencies, but if you're sure we can add these for testing then LGTM.

I don't understand the problem. It's just a test module not even deployed/distributed so adding dependency doesn't have any impact.

Although I still prefer to use Jetty HttpClient for the testing if possible.

The problem is to extract data from the returned HTML. It's not like if parsing HTML was like parsing structured/well-formed data :) We can do it and I will have a try as it's probably not too complicated, but I feel like re-inventing the wheel.

olamy commented 2 months ago

@lachlan-roberts using our own Jetty HttpClient done