Fixes #12318 SecurityUtils should not elminate calls to existing methods

jetty / jetty.project

Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more

https://eclipse.dev/jetty

Other

3.86k stars 1.91k forks source link

Closed stoty closed 3 weeks ago

stoty commented 4 weeks ago

Thank you for the review, I have tried to address your comments.

Shouldn't we use CAPS for the methodHandle constants ?

gregw commented 4 weeks ago

Shouldn't we use CAPS for the methodHandle constants ?

We have a bit of a mixed usage of CAPS for private static final fields, so I'd follow the style of the existing fields in this class.

gregw commented 4 weeks ago

@olamy can you look at CI failure? Doesn't look like a flake, but then doesn't look related to this PR either.

olamy commented 3 weeks ago

@gregw build is fine but @stoty need to sign Eclipse CLA

@stoty please have a read here https://www.eclipse.org/legal/eca/ once you have signed let us know and we will revalidate the PR

stoty commented 3 weeks ago

Thank you. I have signed the ECA.

olamy commented 3 weeks ago

Thank you. I have signed the ECA.

@stoty perfect. PR validated Thanks!