search

jetty / jetty.project

Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more
https://eclipse.dev/jetty
Other
3.86k stars 1.91k forks source link

Jetty 12.1.x fix context handler test #12450

Closed janbartel closed 2 weeks ago

janbartel commented 2 weeks ago

Remove @Disabled from ContextHandlerTest.testSetTempDirectoryBad method.

janbartel commented 2 weeks ago

@olamy can you have a look at this test? It fails on CI but does not fail locally. It should throw an IllegalStateException, from this line here: https://github.com/jetty/jetty.project/blob/jetty-12.1.x-fix-ContextHandlerTest/jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/handler/ContextHandler.java#L795

olamy commented 2 weeks ago

@janbartel Yes, Tests are running as root. So it makes sense.

olamy commented 2 weeks ago

@janbartel I need to do some tests if I can run as not root (but I don't think because of Docker)