Question about org.eclipse.jetty.server.LowResourceMonitor#setMonitorThreads

[lijinliangyihao]

Jetty Version latest Jetty Environment

Java Version

Question

At jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/LowResourceMonitor.java#setMonitorThreads(boolean monitorThreads). Here's the code, if the param monitorThreads is false then nothing will happen.

public void setMonitorThreads(boolean monitorThreads)
    {
        if (monitorThreads)
            // already configured?
            if (!getMonitorThreads())
                addLowResourceCheck(new ConnectorsThreadPoolLowResourceCheck());
            else
                getBeans(ConnectorsThreadPoolLowResourceCheck.class).forEach(this::removeBean);
    }

Should it be

public void setMonitorThreads(boolean monitorThreads)
    {
        if (monitorThreads) {
            // already configured?
            if (!getMonitorThreads())
                addLowResourceCheck(new ConnectorsThreadPoolLowResourceCheck());
        } else
            getBeans(ConnectorsThreadPoolLowResourceCheck.class).forEach(this::removeBean);
    }

?