JettyClientContainerProvider does not actually use common objects correctly

jetty / jetty.project

Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more

https://eclipse.dev/jetty

Other

3.86k stars 1.91k forks source link

JettyClientContainerProvider does not actually use common objects correctly #1766

Closed joakime closed 7 years ago

joakime commented 7 years ago

After a review of JettyClientContainerProvider, the commonExecutor and commonBufferPool does not behave in the way intended.

These concepts (introduced in 9.4.6) are not valid as implemented. Lets remove them in favor of the common HttpClient and singleton approaches instead.

joakime commented 7 years ago

@sbordet those 2 fields have been removed. Please retest cometd.