jetty / jetty.project

Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more
https://eclipse.dev/jetty
Other
3.79k stars 1.9k forks source link

Review Uptime #3515

Open sbordet opened 5 years ago

sbordet commented 5 years ago

Uptime is currently a static singleton with a nested interface and implementation that are apparently not used.

Furthermore, it reports the uptime of the JVM while it is mostly used to report the Server uptime.

In the case of Server restarts, for example, it won't report the restarted Server uptime.

Why does this class need to support Android?

joakime commented 5 years ago

See: https://bugs.eclipse.org/443652

Android (and also JRE on compact3) does not have java.lang.management.ManagementFactory.

sbordet commented 5 years ago

I don't think we support Jetty (the server) on Android. Do we still need to support compact3?

joakime commented 5 years ago

We do support Jetty (the server) on Android v11+. We should ask jetty-users (and jetty-dev) if compact3 is still needed.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 3 weeks ago

This issue has been automatically marked as stale because it has been a full year without activity. It will be closed if no further activity occurs. Thank you for your contributions.