search

jetty / jetty.project

Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more
https://eclipse.dev/jetty
Other
3.86k stars 1.91k forks source link

h2spec tests fail to run #5354

Closed sbordet closed 3 years ago

sbordet commented 4 years ago

Jetty version 9.4.x

Description Installed docker as specified here - in particular, for Ubuntu, not apt install docker, but as documented apt-get install docker-ce docker-ce-cli containerd.io.

Tried to run the h2spec tests yields:

[INFO] docker-machine executable was not found on PATH ([/home/simon/programs/jdk15/bin, /home/simon/.cargo/bin, /home/simon/bin, /usr/local/sbin, /usr/local/bin, /usr/sbin, /usr/bin, /sbin, /bin, /usr/games, /usr/local/games, /snap/bin])

Trying branch jetty-9.4.x_skip_h2spec_if_no_docker yields:

[INFO] --- h2spec-maven-plugin:1.0.1-SNAPSHOT:h2spec (h2spec) @ http2-server ---
[INFO] docker-machine executable was not found on PATH ([/home/simon/programs/jdk15/bin, /home/simon/.cargo/bin, /home/simon/bin, /usr/local/sbin, /usr/local/bin, /usr/sbin, /usr/bin, /sbin, /bin, /usr/games, /usr/local/games, /snap/bin])
[INFO] Found Docker environment with local Unix socket (unix:///var/run/docker.sock)
[INFO] Docker host IP address is localhost
[INFO] Connected to docker: 
  Server Version: 19.03.13
  API Version: 1.40
  Operating System: Ubuntu 20.04.1 LTS
  Total Memory: 31916 MB
[WARNING] Failure when attempting to lookup auth config (dockerImageName: testcontainers/ryuk:0.3.0, configFile: /home/simon/.docker/config.json. Falling back to docker-java default behaviour. Exception message: /home/simon/.docker/config.json (No such file or directory)
[INFO] Starting to pull image
[INFO] Pulling image layers:  0 pending,  0 downloaded,  0 extracted, (0 bytes/0 bytes)
[INFO] Pulling image layers:  2 pending,  1 downloaded,  0 extracted, (2 MB/? MB)
[INFO] Pulling image layers:  1 pending,  2 downloaded,  0 extracted, (4 MB/? MB)
[INFO] Pulling image layers:  1 pending,  2 downloaded,  1 extracted, (4 MB/? MB)
[INFO] Pulling image layers:  1 pending,  2 downloaded,  2 extracted, (4 MB/? MB)
[INFO] Pulling image layers:  1 pending,  2 downloaded,  3 extracted, (5 MB/? MB)
[INFO] Ryuk started - will monitor and terminate Testcontainers containers on JVM exit
[INFO] Checking the system...
[INFO] ✔︎ Docker server version should be at least 1.6.0
[INFO] ✔︎ Docker environment should have more than 2GB free disk space
2020-09-28 09:52:48.543:INFO::Thread-4: Logging initialized @27368ms to org.eclipse.jetty.util.log.StdErrLog
2020-09-28 09:52:48.574:INFO:oejs.Server:Thread-4: jetty-9.4.32-SNAPSHOT; built: 2020-09-28T07:45:31.737Z; git: a5b887d13138af825593b2e6091ba111cb5f5d5c; jvm 15+36-1562
2020-09-28 09:52:48.589:INFO:oejs.AbstractConnector:Thread-4: Started ServerConnector@42fd2f8d{HTTP/1.1, (http/1.1, h2c)}{0.0.0.0:39383}
2020-09-28 09:52:48.589:INFO:oejs.Server:Thread-4: Started @27414ms
[INFO] !!! Exclude specs
[INFO] 3.5 - Sends invalid connection preface
[INFO] running image: summerwind/h2spec:2.6.0 with command: -h host.testcontainers.internal -p 39383 -j /tmp/junit.xml -o 2 --max-header-length 4000
[INFO] Pulling docker image: testcontainers/sshd:1.0.0. Please be patient; this may take some time but only needs to be done once.
[INFO] Starting to pull image
[INFO] Pulling image layers:  0 pending,  0 downloaded,  0 extracted, (0 bytes/0 bytes)
[INFO] Pulling image layers:  1 pending,  1 downloaded,  0 extracted, (20 KB/? MB)
[INFO] Pulling image layers:  1 pending,  1 downloaded,  1 extracted, (1 MB/? MB)
[INFO] Pulling image layers:  0 pending,  2 downloaded,  1 extracted, (2 MB/3 MB)
[INFO] Pulling image layers:  0 pending,  2 downloaded,  2 extracted, (3 MB/3 MB)
[INFO] Pull complete. 2 layers, pulled in 1s (downloaded 3 MB at 3 MB/s)
[INFO] Creating container for image: testcontainers/sshd:1.0.0
[INFO] Starting container with ID: e50f4893b199012f2a4fd26e9a5c9c14b85799ea40589e3d0973f0efc11b4b33
[INFO] Container testcontainers/sshd:1.0.0 is starting: e50f4893b199012f2a4fd26e9a5c9c14b85799ea40589e3d0973f0efc11b4b33
[INFO] Container testcontainers/sshd:1.0.0 started in PT3.74023695S
[INFO] Pulling docker image: summerwind/h2spec:2.6.0. Please be patient; this may take some time but only needs to be done once.
[INFO] Starting to pull image
[INFO] Pulling image layers:  0 pending,  0 downloaded,  0 extracted, (0 bytes/0 bytes)
[INFO] Pulling image layers:  4 pending,  1 downloaded,  0 extracted, (423 bytes/? MB)
[INFO] Pulling image layers:  3 pending,  2 downloaded,  0 extracted, (273 KB/? MB)
[INFO] Pulling image layers:  2 pending,  3 downloaded,  0 extracted, (23 MB/? MB)
[INFO] Pulling image layers:  1 pending,  4 downloaded,  0 extracted, (23 MB/? MB)
[INFO] Pulling image layers:  1 pending,  4 downloaded,  1 extracted, (25 MB/? MB)
[INFO] Pulling image layers:  1 pending,  4 downloaded,  2 extracted, (25 MB/? MB)
[INFO] Pulling image layers:  1 pending,  4 downloaded,  3 extracted, (25 MB/? MB)
[INFO] Pulling image layers:  1 pending,  4 downloaded,  4 extracted, (25 MB/? MB)
[INFO] Pulling image layers:  0 pending,  5 downloaded,  4 extracted, (28 MB/30 MB)
[INFO] Pulling image layers:  0 pending,  5 downloaded,  5 extracted, (30 MB/30 MB)
[INFO] Pull complete. 5 layers, pulled in 3s (downloaded 30 MB at 10 MB/s)
[INFO] Creating container for image: summerwind/h2spec:2.6.0
[INFO] Starting container with ID: 370282c1c029399bf80cb45cfdd963aa897f6dd31113778513efcf5380687a90
[INFO] Container summerwind/h2spec:2.6.0 is starting: 370282c1c029399bf80cb45cfdd963aa897f6dd31113778513efcf5380687a90
[INFO] Container summerwind/h2spec:2.6.0 started in PT6.160675663S
[INFO] All test cases passed. 1 test cases ignored.

But the h2spec tests are not run, or at least there is no evidence that they are actually run.

olamy commented 3 years ago

will not run now if docker not installed