jetty / jetty.project

Eclipse Jetty® - Web Container & Clients - supports HTTP/2, HTTP/1.1, HTTP/1.0, websocket, servlets, and more
https://eclipse.dev/jetty
Other
3.86k stars 1.91k forks source link

getting malformed DTD error for configure.dgtd #8939

Closed goodale closed 1 year ago

goodale commented 1 year ago

Jetty version(s) Jetty 11.0.12

Java version/vendor (use: java -version) 17 Adoptium JDK

OS type/version Linux/Windows

IDE Spring Tool Suite 4.16.1 (Eclipse 4.25.0)

Description

I am getting the warning in jetty-plus.xml, "The markup declarations contained or pointed to by the document type declaration must be well formed"

I have the following in /src/test/config/jetty-plus.xml

<?xml version="1.0"?>
<!DOCTYPE Configure PUBLIC "-//Jetty//Configure//EN" "http://www.eclipse.org/jetty/configure.dtd">
<Configure id="Server" class="org.eclipse.jetty.server.Server">
  <Call name="addBean">
    <Arg>
      <New id="DeploymentManager" class="org.eclipse.jetty.deploy.DeploymentManager">
        <Set name="contexts">
          <Ref refid="Contexts" />
        </Set>
        <Call id="webappprovider" name="addAppProvider">
          <Arg>
            <New class="org.eclipse.jetty.deploy.providers.WebAppProvider">
              <Set name="monitoredDirName"><Property name="jetty.base" default="." />/webapps</Set>
              <Set name="configurationClasses">
                <Array type="java.lang.String">
                  <Item>org.eclipse.jetty.webapp.WebInfConfiguration</Item>
                  <Item>org.eclipse.jetty.webapp.WebXmlConfiguration</Item>
                  <Item>org.eclipse.jetty.webapp.MetaInfConfiguration</Item>
                  <Item>org.eclipse.jetty.webapp.FragmentConfiguration</Item>
                  <Item>org.eclipse.jetty.plus.webapp.EnvConfiguration</Item>
                  <Item>org.eclipse.jetty.plus.webapp.PlusConfiguration</Item>
                  <Item>org.eclipse.jetty.annotations.AnnotationConfiguration</Item>
                </Array>
              </Set>
            </New>
          </Arg>
        </Call>
      </New>
    </Arg>
  </Call>
</Configure>

How to reproduce?

  1. Setup pom to include Jetty 11.0.12
  2. Setup jetty-plus in the resources/test
  3. validate
sbordet commented 1 year ago

What if you use:

<!DOCTYPE Configure PUBLIC "-//Jetty//Configure//EN" "https://www.eclipse.org/jetty/configure_10_0.dtd">
goodale commented 1 year ago

That works! Prior to submitting the issue I tried https://www.eclipse.org/jetty/configure_11_0.dtd but got a 404.

I'll leave the issue open as I presume this means the DTD file is missing as part of the v11 branch and/or deployment to Eclipse.org

sbordet commented 1 year ago

There is no configure_11_0.dtd since version 10 is the most updated one.