Build checking

[jmcc0nn3ll]

We ran across the following error trying to deploy the website for the latest releases. If you look at the source file it is clearly an issue with a commit last week from @janbartel which was not caught by anything from Jenkins, or if it was it was not well reported to get fixed?

@olamy I thought you had setup a build to catch these things?

15:43:24 [INFO] [INFO] ------------------------------------------------------------------------ 15:43:24 [INFO] [INFO] BUILD SUCCESS 15:43:24 [INFO] [INFO] ------------------------------------------------------------------------ 15:43:24 [INFO] [INFO] Total time: 05:21 min 15:43:24 [INFO] [INFO] Finished at: 2024-07-08T15:43:24Z 15:43:24 [INFO] [INFO] ------------------------------------------------------------------------ 15:43:30 [INFO] [exec] java -cp $RUN_JETTY_CLASSPATH org.eclipse.jetty.tests.testers.RunJetty --jetty-home=$JETTY_HOME 15:43:31 [INFO] [exec] java -cp $RUN_JETTY_CLASSPATH org.eclipse.jetty.tests.testers.RunJetty --jetty-home=$JETTY_HOME --args="--add-modules=http" --highlight="([a-z-]+ transitively enabled)" 15:43:32 [INFO] [exec] java -cp $RUN_JETTY_CLASSPATH org.eclipse.jetty.tests.testers.RunJetty --jetty-home=$JETTY_HOME --args="--module=http" --highlight="({.:8080})" 15:43:35 [INFO] [exec] java -cp $RUN_JETTY_CLASSPATH org.eclipse.jetty.tests.testers.RunJetty --jetty-home=$JETTY_HOME --args="--module=http jetty.http.port=9999" --highlight="({.:9999})" 15:43:38 [INFO] [exec] java -cp $RUN_JETTY_CLASSPATH org.eclipse.jetty.tests.testers.RunJetty --jetty-home=$JETTY_HOME --args="--module=http jetty.http.port=8080" --highlight="({.:8080})" 15:43:41 [INFO] [exec] java -cp $RUN_JETTY_CLASSPATH org.eclipse.jetty.tests.testers.RunJetty --jetty-home=$JETTY_HOME --setup-args="--add-modules=http" --args="--add-modules=ee10-deploy" 15:43:43 [INFO] [exec] java -cp $RUN_JETTY_CLASSPATH org.eclipse.jetty.tests.testers.RunJetty --jetty-home=$JETTY_HOME --setup-args="--add-modules=http,deploy,ee10-demo-simple" --highlight="WebAppContext" 15:43:47 [INFO] [15:43:47.549] WARN (asciidoctor): id assigned to section already in use: jetty 15:43:47 [INFO] file: documentation/jetty/modules/operations-guide/pages/deploy/index.adoc:203 15:43:47 [INFO] source: https://github.com/jetty/jetty.project (branch: jetty-12.0.x | start path: documentation/jetty)

[jmcc0nn3ll]

https://jenkins.webtide.net/blue/organizations/jenkins/website%2Fjetty.website/activity/

This build should run whenever there is a commit under documentation/jetty and should report failures, @joakime fired this build manually.

[joakime]

See this build (kicked off manually) to see the error.

https://jenkins.webtide.net/blue/organizations/jenkins/website%2Fjetty.website/detail/main/29/pipeline

@olamy I made the following change to (hopefully) address the issue ...

https://github.com/jetty/jetty.project/commit/803fe5c86b380fe9eaf27351be41aba77eacfa2b

[olamy]

arghh true I forgot to add some triggers based on jetty10/11/12 branches push.

[janbartel]

There's something wrong with the local maven build then too because I built the doco according to the README several times and didn't see an error.

[olamy]

There's something wrong with the local maven build then too because I built the doco according to the README several times and didn't see an error.

Did you build after Joakim fix? Per default, the build here use jetty-12.0.x branch so if you want to test your PR this need some manual changes here https://github.com/jetty/jetty.website/blob/8975f7f4941940433044994d29fdc5948e207f40/antora-playbook.yml#L32

[janbartel]

@olamy dunno, didn't know there was something manual required, I just used the readme and my branch.

[olamy]

no worries. nothing was really defined there. I will add some auto triggering, and we will get informed, and people will get really blamed with automatic bank transfer to the "build failure jar"!