Closed joe-hidden closed 7 years ago
Looks nice. I really like the Extruder and c̷h̷a̷m̷b̷e̷r̷ HBP options. I've been manually editing my own build to limit platform temp for a heated chamber that I don't want to exceed 80C. I usually have it set to 70. Would it make more sense to approach this differently and just let us define the temperatures in the platforms.py file like we do with 'PLATFORM_AXIS_LENGTHS etc? 'PLATFORM_AXIS_LENGTHS={285L, 152L, 155L, 100000L, 100000L}',
This way we can have the defaults defined but add our own temperatures instead of fixed.
/# EXAMPLE /# CUSTOM_TEMPS -- Temperature limits (EXTRUDER, PLATFORM) /# (default: {280,130})
'CUSTOM_TEMPS={320, 150}',
or in my case 'CUSTOM_TEMPS={300, 80}',
@natewin : i like this approach, i admit, this is much better than mine ;-)
You inspired me. Honestly I would struggle to implement it and may not get it right. Is it something you'd update this branch with?
@natewin : lets see whether and how this and the other changes get handled and accepted. depends on how the owner are here. in the case they are team-players there would be no reason for me NOT to contribute more ..... your suggestion as well as some other spooky ideas i (we) have in mind. We means i am not alone here. A friend joins in deliviering ideas and testing, but he is not willing to code (or maybe has no experince in that :-))
well my friend, you inspired me too, my current fork is updated to your idea, but
HEATER_CUSTOM_LIMIT={10,10}
as well as
HEATER_CUSTOM_LIMIT={500,300}
so be smart.....
clone it, compile it, test it ;-) greetings
2017-01-06 17:36 GMT+01:00 natewin notifications@github.com:
You inspired me. Honestly I would struggle to implement it and may not get it right. Is it something you'd update this branch with?
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jetty840/Sailfish-MightyBoardFirmware/pull/174#issuecomment-270943987, or mute the thread https://github.com/notifications/unsubscribe-auth/AORoLs-YfzszN5d2wLlsxJBpXsFv3c6yks5rPm2kgaJpZM4Lcxvy .
Nice changes. Thanks!
I made quiet some uptdates, less to the code and more to the environment:
The side effect from migrating to the recent compiler is, that another ~10% of flash is saved, so the mighty_one build shrunk from slightly over 121000byte to 108525byte, make room for whatever you like.