jetty840 / Sailfish-MightyBoardFirmware

Sailfish, faster than a Marlin
117 stars 76 forks source link

True pwm fan #183

Open pszczelaszkov opened 7 years ago

pszczelaszkov commented 7 years ago

This modification was done to complete slic3r autocooling feature which i was using. It enables reading fan value from .x3g without losing backward compatibility(1% still means set EEPROM value while 2-100 just sets the value). This way it works with replicatorG and slic3r at the same time. It also comes with working fan pause/unpause from build menu, displays fan percentage in build status, and fixes little bug when pausing 100% fan. I ve been testing it for a while, till this day works perfectly.

The only catch is that it accepts value as 0-100 instead of 0-255. Did that to nicely merge with current loading value from EEPROM.

dnewman-polar3d commented 7 years ago

Looks nice; may be a bit before I can pull it in. I have to sort through some issues with a prior contribution and I've simply not had time to do so.

What is the change to the home axes script?

pszczelaszkov commented 7 years ago

Yeah i forgot to create separate branch. It just modifies order first Z goes up to max then down and then XY is homing and in the end Z goes up. This way i dont have problems with homing after leveling since its not hitting clippers.

SaschaKP commented 6 years ago

This won't work on my side, on atmega2560, replicator 1 clone.

I've inspected closely the code, but at the moment haven't found why it only listens to the eeprom saved value and not the ones I'm sending through the commands.

Are you using M126 S1<->100 (eg M126 S10 for 10%) right?

It only works, for me, only on setting via the menu buttons, with eeprom.

EDIT: Nevermind, found out by myself that the original GPX converter only sends 1 or 0. I recompiled mine version of GPX