Create encrypted folder wizard: A forward slash is appended to the path of the encrypted folder

jetwhiz / encfs4win

Windows port of EncFS

https://encfs.win

Other

402 stars 41 forks source link

Create encrypted folder wizard: A forward slash is appended to the path of the encrypted folder #38

Open Zero3 opened 8 years ago

Zero3 commented 8 years ago

When creating a new encrypted folder by passing a non-existing path as the first argument, encfs4win displays the path with a trailing forward slash.

For example, with C:\Encrypted as the path to the encrypted folder:

The directory "C:\Encrypted/" does not exist. Should it be created? (y,n)

While forward slashes are valid directory separators under some circumstances on Windows, backslashes are used almost universally. I would thus expect encfs4win to use a backslash in this situation. I have not checked whether encfs4win displays forward slashes in other messages than this one, but I would not be surprised if it did.

jetwhiz commented 8 years ago

This is mostly a cosmetic issue, since all paths are run though utf8_to_wfn() before being used (which will ensure the path is in the proper format for Windows).

Zero3 commented 8 years ago

On a related note, there is an irregularity in which paths that slashes are appended to:

C:\Program Files (x86)\encfs>encfs D:\Enc D:\Dec
The directory "D:\Enc/" does not exist. Should it be created? (y,n) y
The directory "D:\Dec" does not exist. Should it be created? (y,n) y

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Zero3 commented 5 years ago

Arhhh!! Bugger off, stalebot! Just because nobody posted anything in a while doesn't mean that the bug was automagically fixed...

@jetwhiz Could you help reopen?

jetwhiz commented 5 years ago

Hi @Zero3 -- just reopened, let me know if there are other issues of yours that it closed and should stay open!

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Zero3 commented 5 years ago

@jetwhiz Just a friendly FYI: I don't intend to contribute any more bug reports to encfs4win when they get automatically closed by stalebot, as that is very discouraging.

jetwhiz commented 5 years ago

Sorry about that @Zero3, I forgot to add the enhancement label to the exempt list for stalebot.

I've made it so that enhancement issues can't be marked as stale, and also bumped up the time-to-close to two weeks to give people more time to respond to incorrectly-marked issues.

Stalebot is intended to help keep the issue backlog clean in cases where the issue creator is not responding and the problem has not been able to be confirmed or reproduced.