jevan13 / pe

0 stars 0 forks source link

Able to edit email to not follow constraints #8

Open jevan13 opened 1 week ago

jevan13 commented 1 week ago

Step to reproduce: edit 1 e/john@example

Screenshot 2024-11-15 at 5.01.07 PM.png

Screenshot 2024-11-15 at 5.00.30 PM.png

nus-pe-script commented 1 week ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Able to add email to not follow constraints

  • It is understood from the elderly fields section that email has to follow the format local-part@domain, with domain having a domain label separated with a period
  • Add function allows users to add email without following this constraint
  • Defeats the purpose of having this constraint mentioned
  • Causes major inconvenience by allow this, as users can accidentally save an email without the domain label, and therefore unable to retrieve the actual full email from the application
  • Feature does not work as intended

Step to reproduce: add i/S5987099H n/Jessy Doe p/98765432 e/johnd@example a/311, Clementi Ave 2, #02-25 c/7 t/wheelchairUser t/livingAlone

Screenshot 2024-11-15 at 5.01.07 PM.png


[original: nus-cs2103-AY2425S1/pe-interim#2664] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

as users can accidentally save an email without the domain label

This is not true, as example is already a domain label, in your example johnd@example

From our user guide you screenshotted, it states that:

This domain name is made up of domain labels

It does not mention that there must be two or more domain labels, there can just be one domain label like in johnd@example

In addition, since there is only one domain label, there is nothing to separate with periods. Hence, we are rejecting this bug.

We lowered the severity to Low since having more flexibility in the email validation is unlikely to affect normal operations of the product as users can still input the elderly's emails as required.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


## :question: Issue response Team chose [`response.Rejected`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]
## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [ ] I disagree **Reason for disagreement:** [replace this with your explanation]