search

jeverd / lecture-experience

:books: Liteboard.io - A lightweight browser-based lecturing platform using WebRTC :pencil2:
MIT License
302 stars 34 forks source link

Upload PDF Document to the Board #104

Closed sherman-grewal closed 4 years ago

sherman-grewal commented 4 years ago

Purpose The purpose of this ticket is to allow the host to upload their PDF document to their whiteboard. How to test

  1. Create a new lecture
  2. Click the add image button on the top left toolbar
  3. Select a PDF file
  4. Verify that all of the pages of the PDF file have been added on separate boards. Once the pages have been uploaded, you should be redirected to the board with the first page of the pdf. Screenshots & Other Images/Videos Screen Shot 2020-09-09 at 9 41 47 AM
lnogueir commented 4 years ago

Also, I think that, since we're using the same button to insert images and pdfs to the canvas, we should update the button icon to make more sense.

lnogueir commented 4 years ago

I realized that when we upload a pdf if I try to upload that same pdf again at a later time, it doesn't work. I'll take a look to see why this is happening

lnogueir commented 4 years ago

I realized that when we upload a pdf if I try to upload that same pdf again at a later time, it doesn't work. I'll take a look to see why this is happening

This issue actually happened also before with images. I'll push changes that fix it

lnogueir commented 4 years ago

@sherman-grewal I fixed those issues I mentioned above. Please check if I messed up anything you added.

sherman-grewal commented 4 years ago

Looks good to me, thanks @lnogueir for the review 👍

lnogueir commented 4 years ago

@jeverd deploy to staging and add @sherman-grewal as one of the allowed ips