search

jevey / idapython

Automatically exported from code.google.com/p/idapython
Other
1 stars 0 forks source link

build.py fails on Windows Vista #30

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Build idapython on Windows Vista.

What is the expected output? What do you see instead?
EXPECTED RESULTS:
Successful build.

ACTUAL RESULTS:
  File "build.py", line 343, in build_plugin
    res = builder.compile("idaapi",
UnboundLocalError: local variable 'builder' referenced before assignment

What version of the product are you using? On what operating system?
IDA 5.4, idapython 1.1.90 (svn #170), python 2.5.1.1, Windows Vista SP1.

Additional information:
This is caused by a python problem, regarding the change in the output of 
the windows "ver" command (see: http://bugs.python.org/issue1082 & 
http://bugs.python.org/issue1726668).

The fix is to change build.py line 312 from:
if system == "Windows":
to:
if system == "Windows" or system == "Microsoft":

Allowing the build script to work in both Windows XP and Windows Vista.

l8er
Itai Shaham

Original issue reported on code.google.com by ita...@gmail.com on 20 Apr 2009 at 9:58

Attachments:

GoogleCodeExporter commented 9 years ago 
I fixed this slightly differently. The same comparison is done a bit earlier, I 
just force the system to be correct 
there.

Thanks for the report and the patch!

Original comment by gergely.erdelyi on 26 Apr 2009 at 6:38