search

jexp / jetbrains-heroku-plugin

Heroku Integration for all Jetbrains IDE's
39 stars 13 forks source link

NullPointerException when clicking sidebar buttons on empty lists #30

Open codyharrington opened 10 years ago

codyharrington commented 10 years ago

When you try to remove an item when there are no entries in the list, you get an NPE.

null
java.lang.NullPointerException
    at com.jetbrains.heroku.service.HerokuProjectService.getHerokuAppName(HerokuProjectService.java:66)
    at com.jetbrains.heroku.service.HerokuProjectService.removeConfigVar(HerokuProjectService.java:224)
    at com.jetbrains.heroku.ui.HerokuConfigWindow$2.actionPerformed(HerokuConfigWindow.java:114)
    at com.intellij.openapi.actionSystem.ex.ActionUtil.performActionDumbAware(ActionUtil.java:162)
    at com.intellij.openapi.actionSystem.impl.ActionButton.a(ActionButton.java:170)
    at com.intellij.openapi.actionSystem.impl.ActionButton.a(ActionButton.java:133)
    at com.intellij.openapi.actionSystem.impl.ActionButton.processMouseEvent(ActionButton.java:311)
    at java.awt.Component.processEvent(Component.java:6270)
    at java.awt.Container.processEvent(Container.java:2229)
    at java.awt.Component.dispatchEventImpl(Component.java:4861)

Also, under the Processes tab, if you click Scale Dynos or Scale Workers, you get a NPE:

null
java.lang.NullPointerException
    at com.jetbrains.heroku.service.HerokuProjectService.getHerokuAppName(HerokuProjectService.java:66)
    at com.jetbrains.heroku.service.HerokuProjectService.getProcesses(HerokuProjectService.java:167)
    at com.jetbrains.heroku.service.HerokuProjectService.getProcesses(HerokuProjectService.java:37)
    at com.jetbrains.heroku.ui.HerokuProcessesWindow$1.actionPerformed(HerokuProcessesWindow.java:52)
    at com.intellij.openapi.actionSystem.ex.ActionUtil.performActionDumbAware(ActionUtil.java:162)
    at com.intellij.openapi.actionSystem.impl.ActionButton.a(ActionButton.java:170)
    at com.intellij.openapi.actionSystem.impl.ActionButton.a(ActionButton.java:133)
    at com.intellij.openapi.actionSystem.impl.ActionButton.processMouseEvent(ActionButton.java:311)
    at java.awt.Component.processEvent(Component.java:6270)
    at java.awt.Container.processEvent(Container.java:2229)

Also, under the applications tab, if you click the restart button when there are no items there, you get a NPE:

null
java.lang.NullPointerException
    at com.jetbrains.heroku.service.HerokuProjectService.restartApplication(HerokuProjectService.java:150)
    at com.jetbrains.heroku.ui.HerokuApplicationWindow$1.actionPerformed(HerokuApplicationWindow.java:104)
    at com.intellij.openapi.actionSystem.ex.ActionUtil.performActionDumbAware(ActionUtil.java:162)
    at com.intellij.openapi.actionSystem.impl.ActionButton.a(ActionButton.java:170)
    at com.intellij.openapi.actionSystem.impl.ActionButton.a(ActionButton.java:133)
    at com.intellij.openapi.actionSystem.impl.ActionButton.processMouseEvent(ActionButton.java:311)
    at java.awt.Component.processEvent(Component.java:6270)
    at java.awt.Container.processEvent(Container.java:2229)
    at java.awt.Component.dispatchEventImpl(Component.java:4861)
    at java.awt.Container.dispatchEventImpl(Container.java:2287)

Using PyCharm 3.01 on Fedora 20 java version "1.7.0_45" Java(TM) SE Runtime Environment (build 1.7.0_45-b18) Java HotSpot(TM) 64-Bit Server VM (build 24.45-b08, mixed mode)