search

jexp / neo4j-shell-tools

A bunch of import/export tools for the neo4j-shell
288 stars 55 forks source link

Added binary input option using Kryo #91

Closed Sahasrara closed 8 years ago

jexp commented 8 years ago

A general note. What do you think about making the format an option, as you already encapsulated it in the writer / reader? So you could do -format kryo´ or-format packstreamor-format cbor` ? And defaulting to one?

Sahasrara commented 8 years ago

That sounds like a good idea to me. Adding the format flag to open the door for future binary formats makes sense to me. I'll add that in with the other stuff I'll fix for this pull request. I'll send in another request so that I do everything at once. I just want to make sure I understand some of the other stuff before I start the next revision.

jexp commented 8 years ago

@Sahasrara is it ready to merge or are you still working on it?

Sahasrara commented 8 years ago

That's all I had for now so if you're OK with it, it's good to go.

jexp commented 8 years ago

Merged manually into 2.3 and 3.0 thanks so much !