jeyllani / pinescript

https://marketplace.visualstudio.com/items?itemName=JeylaniB.pinescript
30 stars 13 forks source link

Commenting support #1

Open nickcolea opened 2 years ago

nickcolea commented 2 years ago

Awesome extension. Definitely the most advanced and helpful in the whole marketplace. :)

I've noticed that commenting doesn't seem to trigger with shortcut Ctrl+/.

Is this missing from he extension?

Thanks for all your hard work!

Jos512 commented 2 years ago

Thanks for making this issue, I noticed the same behaviour. If I disable the extension and relaunch, I can use Ctrl + / like usual again. It only happens in the workspace in which the extension is active (in other workspaces, Ctrl + / works as intended).

I'm very happy with this extension, even more so with the beautiful themes, so definitely not complaining. Thanks for your work!

jeyllani commented 2 years ago

Hi ! I just noticed the problem! Indeed, cmd + / or ctrl + / does not work with the extension active! The problem come from a missing important file, somehow I've not noticed that it was missing ! It will be fixed on the next update (that will also fix the hovering issues - wrong multiple matching -). Until the next update if you want to have this issue fixed :

Thank you for reporting it 😃

nickcolea commented 2 years ago

Thank you for the quick follow-up. Love the extension and I've discovered your theme as well. It's works wonders in combination with Pine scripts.

Looking forward to the official update; in the meantime I'll use the fix you provided.

xareelee commented 2 years ago

Hope this issue be fixed quickly!

xilopaint commented 2 years ago

Is this project abandoned?

carloswm85 commented 1 year ago

Hi ! I just noticed the problem! Indeed, cmd + / or ctrl + / does not work with the extension active! The problem come from a missing important file, somehow I've not noticed that it was missing ! It will be fixed on the next update (that will also fix the hovering issues - wrong multiple matching -). Until the next update if you want to have this issue fixed :

* Open vscode/extension folder

* Find jeylaniB.pinescript extension

* Download this file [language-configuration.json](https://github.com/jeyllani/pinescript/blob/main/language-configuration.json) and past it inside

* Restart VSCode and it should work !

Thank you for reporting it 😃

Well, this solution worked like a charm. As far as December 2022, it worked. Thanks for providing it.

By the way, I'd like to suggest you to open a discussion section for this repo.

Good job so far, I hope you can still work on this tooling. Loved it, really.

ozum commented 1 year ago

Any update on this?