search

jeyllani / pinescript

https://marketplace.visualstudio.com/items?itemName=JeylaniB.pinescript
29 stars 12 forks source link

Add matrix.*<> and linefill.*() Snippets #4

Open joebaus opened 2 years ago

joebaus commented 2 years ago

A few things have been added to PineScript recently, like matrices and line fills, that don't currently have snippets.

It starts to make a larger update feel necessary. Is there any sign of an update coming to the extension?

jeyllani commented 2 years ago

Hi ! I will soon release a fully updated version of the extension and a way for the community to contribute!! Sorry for the inconvenience and thank you for your patience ! J

frizLabz-FFriZz commented 2 years ago

i have the code i did all the matrix and a couple of others im new to this whole git hub thing i tried to debug and all that stuff but it was taking too long i got the colors to work on the matrix but not the IntelliSense or emmet whatever it is.. but let me know how i can send you the code it took me a while to do it so im sure it would save you some time or how i can update it with a pull request or even a guide that's not hella confusing.. to be honest, i was probably over complicating it a lot but idk

joebaus commented 2 years ago

Is #6 ready to get pushed out to the extension?

frizLabz-FFriZz commented 2 years ago

Idk i just matched the code i pretty sure i got it right.. im fairly new to coding on something besides pine i tried to get it to work on my end but was having problems.. (not with the code but trying to package it.. if thats even right..) im sure i was just doing one little thing wrong.. but i thought id submit the code and see if it was wrong or right and ask questions then.. but lmk

jeyllani commented 2 years ago

Hi There ! Sorry for the delayed answer, I'll take in count what you did in the pull request. Actually i'm working on the 'hover' pop'up's and remaking them all (correcting wrong/double matches and also the pop up content with the informations + the url to the reference manual --> This take a lot of time as it's done with markdown in typescript) !

For the snippet suggestion you have, my suggestion is to post it here for now and I'll add it manually. As soon as I release the update I publish a contribution.MD explaining how to submit your request !

Very sorry for the waiting time !! And thank you for your patience !!

frizLabz-FFriZz commented 2 years ago

Ok groovy lmk what i did right and what i did wrong and let me know if i can do anything to help you.. your pine syntax is way better done the other couple or so.. ive made a couple of themes you can add to your theme package as well if you'd like i can submit them on there just lmk

JVGH commented 2 years ago

@jeyllani , thanks for your work and looking forward the next update release.

chillax666 commented 2 years ago

Thanks for your work on this project @jeyllani, super useful for converting thinkscript --> pine. Appreciate your work too @FFriZ Will dig into learning how to code these changes if/when I have more spare time but for now I hope this overview of what's missing can help, if only to serve as a checklist.

Missing data types matrix array linefill

Missing functions linefill() linefill.new() linefill.delete() linefill.get_line1() linefill.get_line2() linefill.set_color() request.security_lower_tf() request.economic() str.contains() str.endswith() str.startswith() str.match() str.pos() str.replace() str.upper() str.lower() str.substring() ta.pivot_point_levels() table.cell_set_tooltip() table.cell_set_text_font_family() timeframe.change() timeframe.in_seconds()

Built-ins missing highlighting last_bar_index

Missing built-ins chart.is_heikinashi chart.is_kagi chart.is_linebreak chart.is_pnf chart.is_range chart.is_renko chart.is_standard chart.right_visible_bar_time chart.left_visible_bar_time session.isfirstbar session.isfirstbar_regular session.islastbar session.islastbar_regular display.pane display.price_scale display.status_line display.data_window font.family_default font.family_monospace last_bar_time linefill.all

frizLabz-FFriZz commented 2 years ago

I was planning on finishing this theres a repo on my profile that has arrays matrixs and a few of the other ones but i figured i would hold off until I see what Pine team is up too dont want to waste time if I dont have too https://github.com/tradingview/pine_script_docs/pull/289/files/586ed7cffc496660cdb1ad241e0b1561faaf6d31..584a39233adcbafd3d6915e2023e69f05760f618 @chillax666

xilopaint commented 1 year ago

@chillax666 @FFriZ table.merge_cells is also a missing function.