search

jez / hpstr-theme

A Medium-like Octopress theme based on the HPSTR Jekyll theme.
GNU General Public License v3.0
63 stars 15 forks source link

dlmenu not working #8

Closed benrudolph closed 10 years ago

benrudolph commented 10 years ago

Hi Jake,

I have one more issue that I'm trying to work out. On my site, the dlmenu isn't dropping down on click. It seems to be looking for a dlmenu function that is a jquery plugin. This is undefined on my site, but defined on yours. I found this plugin: http://www.jqueryscript.net/menu/jQuery-Responsive-Multi-Level-Menu-Plugin-Dlmenu.html . Even after including it though the menu doesn't drop down. Am I missing something here? Thanks again for your work on this theme!

Ben

benrudolph commented 10 years ago

Ok, on further investigation, if I call

 $( '#dl-menu' ).dlmenu({
    animationClasses : { classin : 'dl-animate-in', classout : 'dl-animate-out' }
  });

From the console after including jquery.dlmenu.js it works as expected. Perhaps _main.js isn't being loaded? Not sure will investigate further.

jez commented 10 years ago

I have also had issue using dl-menu in the past, and sometimes it seems to start working after I change things that aren't related to fixing it.

You might want to consider updating the theme, as this has been known to fix issues for people in the past. Other than that, let me know if you find something.

It might also be useful to inspect the original Jekyll theme, because when I ported this Octopress theme from that theme, I don't think I touched the JavaScript at all. If there are discrepancies between the two versions, this might help to identify why it's not working.

benrudolph commented 10 years ago

That update did it! Still not sure what was in the upgrade that caused it to be fixed, but for now I'll roll with it. Thank you.