search

jez500 / chorus

A Web UI for XBMC, focused on user experience and music. Get the latest version here: https://github.com/xbmc/chorus2
357 stars 54 forks source link

fix: don't mix timeToSec and formatTime; the 1st one returns a time, and... #25

Closed thorstenhirsch closed 10 years ago

thorstenhirsch commented 10 years ago

... the 2nd one can beautify it.

Hi jez500, I stumbled upon this when I was looking in the code for why the current/total times are sometimes displayed w/o leading zeros (e.g. 1:4:2 instead of 1:04:02). I'm not sure if my little fix really fixes this issue, but I think it helps anyways.

jez500 commented 10 years ago

Thank you! Especially for the fix in buildchorus.sh fix ;) it worked but I couldn't work out where the error came from. I can't seem to replicate the time bug, but looks like a logical fix.

thorstenhirsch commented 10 years ago

You're welcome. I really like chorus' design. :-) There's just one thing I miss compared to AWXi: using my keyboard for navigation. So I tried to add some js:

$(document) .keydown(function (e) { switch (e.which) { case 37: // left $('.fa-chevron-left').click(); break; case 38: // up $('.fa-chevron-up').click(); break; case 39: // right $('.fa-chevron-right').click(); break; case 40: // down $('.fa-chevron-down').click(); break; default: return ; // exit this handler for other keys } e.preventDefault(); // prevent the default action (scroll / move caret) });

...and it works! However I have no clue what might be a good place for this code. And I also guess you're not comfortable selecting the fa-chevron-* (view elements) classes for a controller feature ...so maybe there shouldn't be any binding to a view element at all...?

I'm not a js guy, sorry. Please consider adding this feature, though. If you ask me - I'd like to have the same keybindings as in AWXi:

left - left right - right up - up down - down back - backspace select - return context menu - c

Cheers! Thorsten

2014-04-11 12:21 GMT+02:00 jez500 notifications@github.com:

Thank you! Especially for the fix in buildchorus.sh fix ;) it worked but I couldn't work out where the error came from. I can't seem to replicate the time bug, but looks like a logical fix.

Reply to this email directly or view it on GitHubhttps://github.com/jez500/chorus/pull/25#issuecomment-40189753 .

jez500 commented 10 years ago

Glad you like it :) We missed a couple of secToTime() in the template files but just pushed a fix for that.

Keyboard support will be in the next release. I'll make a controller/keyboard.js and it can handle all keyboard requests, passing commands to the correct controller methods (xbmc vs local). Much better than binding to icons ;)