search

jez500 / chorus

A Web UI for XBMC, focused on user experience and music. Get the latest version here: https://github.com/xbmc/chorus2
357 stars 54 forks source link

Two fixes #94

Open hugegreenbug opened 10 years ago

hugegreenbug commented 10 years ago

Fixes the remote control pad from being 12 px above the main controls div in sass Fixes the now playing title from being cut off in browsers other than crhome in sass

janhicken commented 9 years ago

You changed the files located in the dist folder but these are generated by grunt and compass. I don't really understand why they are checked into the repository anyway.

On the next build, these changes are going to be overridden. In order to make changes to the style.css file, you have to look for the corresponding files in src/theme/**/*.scss. All these files are processed and concatenated into the styles.css using compass.

hugegreenbug commented 9 years ago

I did both, I edited the sass and I checked in the built version. Sorry for checking in the built version, but I did make the changes to the source.

Hugh

On Thu, Jan 15, 2015 at 3:06 AM, Jan notifications@github.com wrote:

You changed the files located in the dist folder but these are generated by grunt and compass. I don't really understand why they are checked into the repository anyway.

On the next build, these changes are going to be overridden. In order to make changes to the style.css file, you have to look for the corresponding files in src/theme/*/.scss. All these files are processed and concatenated into the styles.css using compass.

— Reply to this email directly or view it on GitHub https://github.com/jez500/chorus/pull/94#issuecomment-70063965.

janhicken commented 9 years ago

Nevermind, I'm sorry, didn't recognize you edited them, too. It's just a bit confusing to have all changes listed twice in the commits :)