search

jezdez / envdir

A Python port of daemontools' envdir.
https://envdir.readthedocs.io/
MIT License
229 stars 28 forks source link

Set encoding to utf-8 on reading parts. #42

Closed squidsoup closed 8 years ago

squidsoup commented 9 years ago

Installation of envdir on python3 fails in an environment with no locale/$LANG, as codecs.open() falls back to ASCII.

blueyed commented 8 years ago

Thanks!

It fails on Python 2.6: https://travis-ci.org/jezdez/envdir/jobs/73829855

Can you fix it, please?

blueyed commented 8 years ago

Would be great to have a test also, to trigger the issue that this is fixing.

blueyed commented 8 years ago

The test failure might be fixed with #45.

blueyed commented 8 years ago

JFI: rebasing on master should fix the test failures.

squidsoup commented 8 years ago

Thanks Daniel, looks green now.

On Tue, 24 Nov 2015 at 11:43 Daniel Hahler notifications@github.com wrote:

JFI: rebasing on master should fix the test failures.

— Reply to this email directly or view it on GitHub https://github.com/jezdez/envdir/pull/42#issuecomment-159091290.

blueyed commented 8 years ago

Thank you, merged.