search

jezdez / textmate-missingdrawer

[UNMAINTAINED] A better sidebar for Textmate.
MIT License
724 stars 35 forks source link

MissingDrawer does not work in 10.5.8? #22

Closed melo closed 13 years ago

melo commented 13 years ago

Hi,

I use MissingDrawer perfectly with my 10.6.4 setup, but on the desktop, still running 10.5.8, it fails to load:

9/9/10 11:12:03 AM TextMate[5577] Error loading /Users/melo/Documents/work/textmate/user_config/PlugIns/MissingDrawer.tmplugin/Contents/MacOS/MissingDrawer:  dlopen(/Users/melo/Documents/work/textmate/user_config/PlugIns/MissingDrawer.tmplugin/Contents/MacOS/MissingDrawer, 265): no suitable image found.  Did find: /Users/melo/Documents/work/textmate/user_config/PlugIns/MissingDrawer.tmplugin/Contents/MacOS/MissingDrawer: unknown required load command 0x80000022 
9/9/10 11:12:03 AM TextMate[5577] instance MissingDrawer plug-in has no principal class

Any ideas?

Thanks!

christophmeissner commented 13 years ago

Currently, MD is working with 10.6 only. Hang in there a couple of more days, we will eventually bring back 10.5 support.

melo commented 13 years ago

Ok, thanks! If you need someone to test it with 10.5.8 ping me

christophmeissner commented 13 years ago

@melo: tried to reach you with no response. Anybody else having a 10.5 running and could do some testing?

melo commented 13 years ago

Strange, didn't get any email message about this.

I'm here, and I can test it, which version should I download?

sbarre commented 13 years ago

wish I had read this before upgrading from the old version of the plugin. :-(

If you don't have time to fix this for 10.5 right now, you should at least put that notice prominently in your installation instructions.

Now I've overwritten my old plugin that worked with this new one that doesn't work, and I'm stuck without my pane and using the crappy Gutter..

derekprior commented 13 years ago

I ran into this same issue and tried to figure it out. I'm not an Obj-C programmer, but I took a stab at building this with the 10.5 SDK. Unfortunately, it's not as simple as targeting the 10.5 SDK - The code uses NSSplitViewDelegate in various places. This object is only available in the 10.6 SDK. The code would have to be rewritten to not use this object.

As I said, I'm not a Obj-C developer and certainly not familiar with the Cocoa API, so I can't really do much more than I've already done at this point. Happy to help test though.

derekprior commented 13 years ago

Okay, I played around with this a little bit more and got it "kind of" working on 10.5. All i did was make one small change to "MDSplitView.h" as seen here.

Everything seems to work okay when I open a project. However, there's a bug when launching via the dock icon. I have TM set to create a new empty document when launched. The document gets created but then instantly the textarea disappears.

The issue seems to be in MD_splitWindowIfNeeded. I can't confirm if this is an issue with the current version on 10.6 (as I don't have access to a 10.6 machine right now), or if it's something removing the NSSplitViewDelegate class dependency introduced.

Any ideas? Here's the log output when I see this behavior on launch. Hope I've been some help.

10/28/10 12:53:22 PM TextMate[8672] -[MDSplitView mouseDown:](247):  
10/28/10 12:53:27 PM TextMate[8674] -[MDMissingDrawer initWithPlugInController:](69): initializing 'MissingDrawer' plugin 
10/28/10 12:53:27 PM TextMate[8674] -[MDMissingDrawer _injectPluginMethods](120): swapping OakProjectController methods 
10/28/10 12:53:27 PM TextMate[8674] +[MDMissingDrawer makeSplitViewWithMainView:sideView:](58):  
10/28/10 12:53:27 PM TextMate[8674] -[NSWindowController(MDAdditions) MD_splitWindowIfNeeded](54): replacing current window with split view 
10/28/10 12:53:27 PM TextMate[8674] -[MDSplitView splitView:resizeSubviewsWithOldSize:](203):  
10/28/10 12:53:27 PM TextMate[8674] -[MDSplitView resetCursorRects](237):
derekprior commented 13 years ago

Alright, had some more time to play and got a version working on 10.5. Pull Request submitted. I don't have access to test this on 10.6.

If this isn't pulled in or otherwise addressed shortly and you want a plugin that works with 10.5, you can hit up the downloads on my fork.

soffes commented 13 years ago

10.5 support was added awhile ago. Closing this issue. Please reopen if you still have trouble.