Closed dim13 closed 8 months ago
Many of the files you are changing are autogenerated.
@dim13 As @aarzilli says, many files are autogenerated. Here is the list (obtained with command grep -rl '// This file is automatically generated from'|grep -v xgbgen|sort
):
bigreq/bigreq.go
composite/composite.go
damage/damage.go
dpms/dpms.go
dri2/dri2.go
ge/ge.go
glx/glx.go
randr/randr.go
record/record.go
render/render.go
res/res.go
screensaver/screensaver.go
shape/shape.go
shm/shm.go
xcmisc/xcmisc.go
xevie/xevie.go
xf86dri/xf86dri.go
xf86vidmode/xf86vidmode.go
xfixes/xfixes.go
xinerama/xinerama.go
xprint/xprint.go
xproto/xproto.go
xselinux/xselinux.go
xtest/xtest.go
xvmc/xvmc.go
xv/xv.go
Corrections should be made in the generator (xgbgen) and then files regenerated as last commit.
Yes, you're absolutely right, I've overseen, that many files are generated. This PR as is now, makes no sense then. I would rather close it, and come back with more thought-through solution later.
Rework needed
go vet
gofmt -s