Create constant for 13 instead of having "magic numbers"

jezen / is-thirteen

Check if a number is equal to 13.

5.51k stars 463 forks source link

Create constant for 13 instead of having "magic numbers" #66

Closed haggy closed 8 years ago

haggy commented 8 years ago

The number 13 is sprayed many places around the lib. I suggest that you create a constant aptly named THIRTEEN just in case one of the following scenarios occur:

The number 13 changes
What math currently is becomes something else when machines take over
Something, something quantum mechanics

aeharding commented 8 years ago

+1, this could make switching to 12 easier in the future.

There seems to be a growing consensus by developers that 12 is the new best practice for comparing if it is thirteen.

gytdau commented 8 years ago

@aeharding so I see now that the opinion of one person has become a 'growing consensus'? Blasphemy this is.

aeharding commented 8 years ago

Hey hey hey I have a source

haggy commented 8 years ago

We have further proof that 12 is the new 13

http://12isthenew13.com/

apollocatlin commented 8 years ago

I disagree with everything seen here. You should all be ashamed of yourselves. 13 is 13. How does noone here get it?

gytdau commented 8 years ago

You spent $10 on that. Good work.

aeharding commented 8 years ago

@apollocatlin The web moves quickly and you must be using the latest and greatest or else you aren't cool.

apollocatlin commented 8 years ago

Don't try telling me 14 is the new 13. 13 will ALWAYS be valuable.

haggy commented 8 years ago

@gytdau It was $12.27 with tax. Premium.

apollocatlin commented 8 years ago

@haggy 24/7 phone support?

haggy commented 8 years ago

@apollocatlin It's 12/13 phone support currently.

aeharding commented 8 years ago

@haggy $12.27, you say? coincidence???

haggy commented 8 years ago

@aeharding I think not!

gytdau commented 8 years ago

@jezen we are being overthrown. Send backups.

jezen commented 8 years ago

Freidns please i know programming is like fashion its in one year out the other but comparing with thirteen is serious business and we are a serious project

aeharding commented 8 years ago

Hey we never established what base 13 with in. If it was in base 4 but it was meant to be in base 5, the number should actually be 12!

There is too much evidence to deny here. I mean really.

haggy commented 8 years ago

@jezen Plus, 12 is a valuable number in quantum theory suggesting that it holds the secrets to time travel.

haggy commented 8 years ago

@jezen We now have a lib to help with numbers that are NOT thirteen.

https://www.npmjs.com/package/is-not-thirteen

FYI @aeharding there's a nice function in there for all of us on the 12 side :smile:

gytdau commented 8 years ago

Fixed by #326