search

jeziellago / compose-markdown

Markdown Text for Android Jetpack Compose 📋.
MIT License
508 stars 42 forks source link

Font size is set with DP instead of SP #41

Closed isles1217 closed 1 year ago

isles1217 commented 1 year ago

I just noticed this when looking at the source code for the createTextView method

setTextSize(TypedValue.COMPLEX_UNIT_DIP, mergedStyle.fontSize.value)

This should be changed to the following, to ensure text size scaling settings on the device are honored. 

setTextSize(TypedValue.COMPLEX_UNIT_SP, mergedStyle.fontSize.value)
brahmkshatriya commented 1 year ago

why not create a Pull request?