search

jeziellago / compose-markdown

Markdown Text for Android Jetpack Compose 📋.
MIT License
594 stars 51 forks source link

Can we make SoftBreakAddsNewLinePlugin optional? #87

Closed StephanSchuster closed 7 months ago

StephanSchuster commented 7 months ago

I understand the use case for SoftBreakAddsNewLinePlugin. I also read this issue: https://github.com/jeziellago/compose-markdown/issues/43 And I know your code: https://github.com/jeziellago/compose-markdown/blob/a3896eb128f529ed464bb51cd956a717abe85225/markdowntext/src/main/java/dev/jeziellago/compose/markdowntext/MarkdownRender.kt#L31

Sure, there are use cases where it makes sense to have this plugin. But I don't think it should be the default since it is not in line with Markdown standards.

In any case I think this should be configurable. Any chance to do so?

PS: Apart from that, great library. Maybe at some point with better support for Fonts and LocalContentColor. ;-)

StephanSchuster commented 6 months ago

Thank you! Works as expected.