jezzi23
commented
1 month ago Hey, nice findings.
- Since the Blessing of Light effect appears to depend on Holy Light rank it would be easiest to account for in calc.lua instead of buffs.lua. The codebase may be messy so if you don't find a quick way to do it, don't worry about it and I can work it in next when I can get to it.
- I suspect you have taken Healing Light talent for higher level characters. The addon currently assumes it is applied to the base of the spell and not spell power. If the in-game blizzard tooltip is showing 42-51 rank 1 Holy Light with the talent at higher levels then the addon is wrong and the talent % healing should applied to both base and sp (but not visible from blizz tooltip).
- I wouldn't worry too much about +/- 1 errors for integers in tooltips as they are just rounded for readability. The calculation is done in floating point numbers. A better test is probably seeing if the healing expectation number matches but this requires many samples :)
ritewhose
Hi,
Using Blessing of Light throws off the calculation Holy Light spells. Here is what I've tried so far to figure out what's really happening.
Test Results
Here are my results for doing 10 casts per rank. I then compared these results to what is estimated by using power-as-spell-power (proposed) and power-as-flat-addition (currently used in the source code).
For context, I have 617 healing power from gear.
Analysis
The divergence is most dramatically seen in Holy Light(Rank 1) with Blessing of Light(Rank 3)(bolded). If the current calculations were correct I'd be healing close to 600 per normal cast, and this would be the most mana-efficient heal for Paladins in the game. Unfortunately it's not nearly that powerful: My normal casts are around 260. This is in line with what would be expected from calculating Blessing of Light's effect based on spell power alone.
On the other hand, using spell power does not completely solve the problem. For HL2 and HL3, the results are somewhere in the middle of
spandflat_add; for HL4-HL8, it's clear that theflat_addis quite accurate whilespis not.Lower Rank Holy Light Scaling
So, Rank 2 and Rank 3 are still unsolved. I found the range of the original unbuffed spells, and then started casting until I had achieved the same range with a Blessing of Light. I then took the buffed lower upper bounds and subtracted them from their respective unbuffed bound to compute the diff column. Here are my results from this (T = tooltip info):
Holy Light(Rank 2)
Holy Light(Rank 3)
This shows that Blessing of Light applies different heal power coefficients based on the rank of the spell. Rank 2 is modified by a
0.4coefficient, and Rank 3 is modified by a0.7coefficient. Presumably, higher-ranked spells all use a1.0coefficient.Lastly, I decided to revisit rank 1 with the same methodology:
Holy Light(Rank 1)
So, it seems Holy Light(Rank 1) might have a coefficient of
0.2, and this just happens to be very close to its normal spell power coefficient of0.205, but if that were the case it seems 210.2, for instance, would equal 42, not 43, and 300.2 would equal 60, not 61. It seems it would be slightly more accurate to scale it based on spell power.Implementation
I was hoping this would be pretty straightforward to implement, but it doesn't seem that easy. The calculator is not really built to apply a buff differently to different ranks of the same spell. I did come up with a way to do it, which I'll try to get around to sharing tomorrow.
Holy Light's Effect Ranges Off
This got me most of the way there, but my ranges were still off ever so slightly, being a little higher than expected. While looking into this I noticed Holy Light's effect range changes as you level, but not necessarily in a linear way. For example, here is what the tooltip says for Holy Light(Rank 1) based on several of my characters:
The addon currently assumes a base of 39-47, growing by 0.8 from levels 1-5. This accounts for the scaling at lvl5. However, there is evidently a period of no change for this effect range between at least level 5 and 21, then somewhere between levels 21 and 50 some additional effect range changes. I can say, at least, that this is not affected by gear or buffs as the range persists after removing all gear, and I've cross-checked this behavior with Classic Era (non-SoD) servers.
Given that in my implementation the spell effect ranges are very close but only slightly off in inconsistent ways, it seems like the calculator is taking most of this into account already somehow, either intentionally or accidentally.
Greater Blessing of Light
Currently, Greater Blessing of Light (spid:25890) is not recognized as a Blessing of Light, but should carry the same effects as Blessing of Light(Rank 3).
Additional Spell Notes
Holy Light
Blessing of Light