search

jf-tech / omniparser

omniparser: a native Golang ETL streaming parser and transform library for CSV, JSON, XML, EDI, text, etc.
MIT License
931 stars 68 forks source link

Change the `Transform` coding pattern from `Next() -> Read()` to just `Read()` #110

Closed jf-tech closed 3 years ago

jf-tech commented 3 years ago

Found this Next()->Read() pattern pretty silly and unnecessary. Also current Next() has a useless for {} wrapping loop. Probably from long time ago, but it's not needed.

codecov[bot] commented 3 years ago

Codecov Report

Merging #110 into master will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #110   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           39        39           
  Lines         1759      1749   -10     
=========================================
- Hits          1759      1749   -10
Impacted Files Coverage Δ
transform.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b9cbdad...7532842. Read the comment docs.