jf-tech / omniparser

omniparser: a native Golang ETL streaming parser and transform library for CSV, JSON, XML, EDI, text, etc.
MIT License
931 stars 68 forks source link

Merge `custom_parse` into `custom_func` and retire `custom_parse`? #134

Closed jf-tech closed 3 years ago

jf-tech commented 3 years ago

Previously we created custom_parse because of limitation of return type of a custom_func must be string. Since we revamped custom_func type system because of javascript introduction, seems like there is no reason for custom_parse to exist anymore. custom_parse is simply just another custom_func with transformctx and idr.Node two arguments and an arbitrary interface{} return type.

Should we just deprecate and retire custom_parse?