jfacen0902 / winetricks

Automatically exported from code.google.com/p/winetricks
0 stars 0 forks source link

In-script documentation says "checkbashism", should be "checkbashisms" (plural), and other minor issues #105

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1. Open the script source

2. Line 83 reads "# - 'checkbashism -p -x winetricks' should show no warnings 
(per Debian policy)"

3. Try the suggested command in terminal:

rodrigo@desktop ~ $ checkbashism -p -x winetricks
No command 'checkbashism' found, did you mean:
 Command 'checkbashisms' from package 'devscripts' (main)
checkbashism: command not found

rodrigo@desktop ~ $ checkbashisms -p -x winetricks
cannot open script winetricks for reading: No such file or directory

What is the expected output? What do you see instead?

The proper command is checkbashisms (note the plural). Also, I suggest chaning 
"winetricks" to "`which winetricks`"

checkbashisms -p -x `which winetricks`

(now it works, but find 2 issues:)
possible bashism in /usr/bin/winetricks line 1082 (test -a/-o):
            if test $minsize -gt 1 -a $filesize -ne $minsize
possible bashism in /usr/bin/winetricks line 1087 (test -a/-o):
            if test "$check_sha1" != "" -a "$sha1sum"x != ""x

What version of the product are you using? On what operating system?
WINETRICKS_VERSION=20110629
wine-1.3.23
(both straight from official PPA)
Linux Mint 10 64bit (~ Ubuntu 10.10)

Please provide any additional information below.
Yes, I know im being picky here... but this is my 1st bug report.

Original issue reported on code.google.com by rodrigo....@gmail.com on 3 Jul 2011 at 11:31

GoogleCodeExporter commented 8 years ago
This issue was closed by revision r671.

Original comment by daniel.r...@gmail.com on 5 Jul 2011 at 5:42