jfacen0902 / winetricks

Automatically exported from code.google.com/p/winetricks
0 stars 0 forks source link

r767 bashism error #168

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
What steps will reproduce the problem?
1.get that release
2.chmod +x
3.checkbashisms -p -x /usr/bin/winetricks

What is the expected output? What do you see instead?
simple control to check debian policy

oem@oem-desktop:~$ checkbashisms -p -x /usr/bin/winetricks
possible bashism in /usr/bin/winetricks line 16374 (kill -[0-9] or -[A-Z]):
kill -HUP $_job # just in case

What version of the product are you using? On what operating system?
r767 on ubuntu precise i386 & wine 1.3.37

Please provide any additional information below.

Original issue reported on code.google.com by sparb...@numericable.fr on 27 Jan 2012 at 10:47

GoogleCodeExporter commented 8 years ago
Hmm.  I guess I could test under posh.

What about the line

trap winetricks_cleanup EXIT HUP INT QUIT ABRT

?

Original comment by daniel.r...@gmail.com on 8 Mar 2012 at 6:05

GoogleCodeExporter commented 8 years ago
checkbashism handles kill checking incorrectly. See:

  http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=692058

This issue can be closed.

Original comment by jari.aalto.fi@gmail.com on 1 Nov 2012 at 6:07

GoogleCodeExporter commented 8 years ago
This is fixed (we now do kill -s HUP)

Original comment by austinenglish@gmail.com on 15 Jun 2013 at 10:53