remove unsupported polyfills. - Githubissues

jfairbank / redux-saga-test-plan

Test Redux Saga with an easy plan.

http://redux-saga-test-plan.jeremyfairbank.com

MIT License

1.25k stars 127 forks source link

remove unsupported polyfills. #388

Closed Ne3l closed 2 years ago

Ne3l commented 2 years ago

Remove polyfills for non supported node versions. on https://github.com/jfairbank/redux-saga-test-plan/releases/tag/4.0.0 it was removed the support for versions below 8.0.0

Object assign https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/assign#browser_compatibility (node v4.0)
Map https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Map#browser_compatibility (node v0.12)

Fixes https://github.com/jfairbank/redux-saga-test-plan/issues/334 https://github.com/jfairbank/redux-saga-test-plan/issues/327

jp-reejig commented 2 years ago

LGTM. Thank you very much.

Ne3l commented 2 years ago

@jp-reejig Thanks for reviewing it, do you know when this will be released?

jp928 commented 2 years ago

@Ne3l could you check latest 4.0.5 if it includes your PR?

Ne3l commented 2 years ago

@jp928 No, it still has the previous version. A new release is needed for the changes.

jp928 commented 2 years ago

@Ne3l just release v4.0.6, thanks for your PR