Closed JsseL closed 7 years ago
And of course if this gets merged in, I'd be really happy if you could make a new release including the fix. :smile:
Merging #56 into master will not change coverage. The diff coverage is
100%
.
@@ Coverage Diff @@
## master #56 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 30 30
Lines 225 225
Branches 62 62
=====================================
Hits 225 225
Impacted Files | Coverage Δ | |
---|---|---|
src/validators/hasLengthLessThan.js | 100% <100%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 52026e1...f5adccf. Read the comment docs.
Thanks, @JsseL!
I'll try to get a release out as soon as possible. I have some other features that have been sitting in master, so I'll have to spend a little time finally documenting them for the release too.
@jfairbank any chance you could make that release? I'd really like to get it in production as soon as possible. Thanks.
Hi, @JsseL.
Apologies for the delay. Things have been hectic for me, and I let this slip. I've published v1.2.0 with your fix.
@jfairbank Awesome and I really appreciate that you found time to do the release. Thanks :+1:
This PR supersedes #53 by not just fixing the documentation, but also the incorrect error message. Also checked out
hasLengthGreaterThan
as @jfairbank suggested. Couldn't see a problem there, but did small renaming to make the tests easier to read.Feel free to leave any comments or improvement ideas. I might be pretty busy, but I'll try to make required changes if possible.