search

jfarmer08 / homebridge-wyze-smart-home

Wyze Smart Home plugin for Homebridge.
MIT License
94 stars 14 forks source link

Ignore devices in the log/add support for Wyze Doorbell Pro Cam #137

Closed ExioStar closed 8 months ago

ExioStar commented 11 months ago

Is your feature request related to a problem? Please describe: Yes, the Wyze Doorbell Pro Cam is not supported, but the plugin sees the camera at every refresh interval. I put in the mac address of the chime and the camera to be ignored in the plugin settings, but it still floods the log every 3 minutes that there is an unsupported device.

Or can support be added for the camera?

Describe the solution you'd like: A way to disable unsupported devices from being placed in the homebridge log

Describe alternatives you've considered:

Additional context: [8/5/2023, 3:05:38 PM] [Wyze] Camera (Model: GW_BE1 (Mac: GW_BE1_7C78B2A33FE8 (Name: Front Door) not supported submit a request to https://github.com/jfarmer08/homebridge-wyze-smart-home/issues to have it added. If no issues are found [8/5/2023, 3:08:39 PM] [Wyze] Camera (Model: GW_BE1 (Mac: GW_BE1_7C78B2A33FE8 (Name: Front Door) not supported submit a request to https://github.com/jfarmer08/homebridge-wyze-smart-home/issues to have it added. If no issues are found [8/5/2023, 3:11:39 PM] [Wyze] Camera (Model: GW_BE1 (Mac: GW_BE1_7C78B2A33FE8 (Name: Front Door) not supported submit a request to https://github.com/jfarmer08/homebridge-wyze-smart-home/issues to have it added. If no issues are found [8/5/2023, 3:14:40 PM] [Wyze] Camera (Model: GW_BE1 (Mac: GW_BE1_7C78B2A33FE8 (Name: Front Door) not supported submit a request to https://github.com/jfarmer08/homebridge-wyze-smart-home/issues to have it added. If no issues are found [8/5/2023, 3:17:40 PM] [Wyze] Camera (Model: GW_BE1 (Mac: GW_BE1_7C78B2A33FE8 (Name: Front Door) not supported submit a request to https://github.com/jfarmer08/homebridge-wyze-smart-home/issues to have it added. If no issues are found [8/5/2023, 3:20:41 PM] [Wyze] Camera (Model: GW_BE1 (Mac: GW_BE1_7C78B2A33FE8 (Name: Front Door) not supported submit a request to https://github.com/jfarmer08/homebridge-wyze-smart-home/issues to have it added. If no issues are found

github-actions[bot] commented 11 months ago

Message that will be displayed on users' first issue

carTloyal123 commented 11 months ago

I believe there is a logging option in the plugin configuration that you can set to "none" which will at least get rid of the flood of messages. The filter should be ignoring the device completely so that is unexpected. Will you please post your plugin config from the homebridge json? As far as adding support, what kind of support is of interest? This plugin does not support video streams of any kind and other projects are more appropriate for that work. If non video features are in question definitely note them here to be considered.

jfarmer08 commented 11 months ago

Just looked into this. And it's not following the standard logging function. It will print no matter what. I will try to address this soon, but it does not cause any issues.

ExioStar commented 11 months ago

I believe there is a logging option in the plugin configuration that you can set to "none" which will at least get rid of the flood of messages

It currently is set to none, but it is not following the rules currently. As also noted jfarmer08 said he would look into this.

As far as adding support, what kind of support is of interest?

I know this plugin isn't for video streams, but if a toggle to turn it on or off would be possible, that would be great. There are toggles with the regular Wyze cams I have, but not the Doorbell Cam.

carTloyal123 commented 11 months ago

@jfarmer08 are you okay to change this logging to be under the debug option? If so I can go through and change it in a PR. I do like how it makes it obvious when a product needs support and not hiding that in debug. Maybe an additional option of some kind?

@ExioStar that makes sense. The thing is, the video doorbell pro doesn't have an 'on/off' functionality like the other cameras since it is battery powered (even if hardwired). There are some efforts looking into the VDP in other projects like docker-wyze-bridge

jfarmer08 commented 11 months ago

@carTloyal123 I am working on a few changes, also adding more support for Camera Flood light and Siren.

jfarmer08 commented 8 months ago

https://github.com/jfarmer08/homebridge-wyze-smart-home/releases/tag/v0.5.37-alpha.6