search

jfarmer08 / homebridge-wyze-smart-home

Wyze Smart Home plugin for Homebridge.
MIT License
93 stars 14 forks source link

Update thermostat behavior and update fork branch to be in line with current WyzeAccessory updates #230

Closed carTloyal123 closed 4 months ago

carTloyal123 commented 4 months ago

This PR should address four things:

  1. Refactor of WyzeAccessory to remove thermostat relevant components that were left previously
  2. Update WyzeThermostat to hold all needed functionality inside it's own class and not rely on WyzeAccessory - this is to fall in line with the new structure of the project
  3. Push a fix to an issue where you cannot set the thermostat temp above or below the arbitrary thresholds imposed by Homekit - #203
  4. Fix for constant reboot when using thermostat - #228
carTloyal123 commented 4 months ago

@jfarmer08 feel free to take a look at this and give it a test locally. Works locally on my side but would appreciate a few other people trying it to make sure I did not break anything outside the thermostat. I only have two cameras and thermostat so not a great range of variables being tested.

jfarmer08 commented 4 months ago

The CHANGELOG.md log should reflect the change of this PR.

carTloyal123 commented 4 months ago

@jfarmer08 any other notes on this?

jfarmer08 commented 4 months ago

I don't have a thermostat so I cannot test that, but I did test with my 83 other products and didn't see any issue.

carTloyal123 commented 4 months ago

@jfarmer08 do you actually have 83 wyze products or you just have a bunch?

jfarmer08 commented 4 months ago

Yeah I have about that many.